Jefffrey commented on PR #5065: URL: https://github.com/apache/arrow-rs/pull/5065#issuecomment-1819762082
> This looks good to me, my only comment is I think it should be `keep_null_values` or possibly `preserve_nulls`, as null keys are actually illegal in JSON 😅 Yeah I wasn't sure on the proper name. I was gonna leave it as `keep_nulls` but I felt that could be confusing since it might imply affecting null values in arrays which should always be kept regardless. Maybe something like `preserve_object_nulls`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
