zeodtr commented on issue #7698: URL: https://github.com/apache/arrow-datafusion/issues/7698#issuecomment-1820101466
@alamb I've read the discussions you shared. Thank you. Since I'm not quite proficient at Rust, I might not be able to add a useful comment there. However, I do have some general feelings: * I noticed that the discussions primarily focus on coding style and convenience rather than the performance of the code. * The mention of a deep comparison (between Exprs) raises concerns regarding potential performance issues. * I'm uncertain about the necessity of unifying the coding style between trait and enum. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
