ozankabak commented on code in PR #8276:
URL: https://github.com/apache/arrow-datafusion/pull/8276#discussion_r1400092868
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -3281,7 +3279,7 @@ mod tests {
(
col("c3"),
NullableInterval::NotNull {
- values: Interval::make(Some(0_i64), Some(2_i64), (false,
false)),
+ values: Interval::make(Some(0_i64), Some(2_i64)).unwrap(),
Review Comment:
`make` is a utility function for use in tests only. Using `try_new` in test
functions balloons the line count 🙂 I am adding a comment in the docstring to
make this clear.
BTW I tried a few tricks to make this a test-only function (using config
directives, moving to a separate `test_utils.rs` file etc.), but it is not very
straightforward since this is used in tests of multiple crates. One way I was
able to make it work was via feature flags, but since that is a more involved
change I decided not to put it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
