pitrou commented on code in PR #38784:
URL: https://github.com/apache/arrow/pull/38784#discussion_r1400708489


##########
cpp/src/parquet/encoding.cc:
##########
@@ -1983,7 +1990,7 @@ class DictByteArrayDecoderImpl : public 
DictDecoderImpl<ByteArrayType>,
     int values_decoded = 0;
 
     ArrowBinaryHelper<ByteArrayType> helper(out, num_values);
-    RETURN_NOT_OK(helper.Prepare(len_));
+    RETURN_NOT_OK(helper.Prepare());

Review Comment:
   I still don't understand why we don't want to presize here.... This can be 
called for non-dict decoding, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to