korowa commented on code in PR #8251:
URL: https://github.com/apache/arrow-datafusion/pull/8251#discussion_r1401004666
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -73,6 +73,8 @@ impl TableProviderFactory for ListingTableFactory {
CsvFormat::default()
.with_has_header(cmd.has_header)
.with_delimiter(cmd.delimiter as u8)
+ .with_quote(cmd.options.get("quote").map_or(b'"', |x|
x.as_bytes()[0]))
+ .with_escape(cmd.options.get("escape").map_or(None, |x|
Some(x.as_bytes()[0])))
.with_file_compression_type(file_compression_type),
Review Comment:
TBH I'd prefer to file a separate issued and integrate `QUOTE` & `ESCAPE`
into `CreateExternalTable` pipeline. My concern here is that it probably will
be confusing for end-users to pass read options into clause reserved for write
options (and without any effect on writing CSV).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
