alamb commented on PR #8288: URL: https://github.com/apache/arrow-datafusion/pull/8288#issuecomment-1821619370
> I worry this might be fragile if IDEs choose to enable other options. I agree it is fragile (but easy to fix) > I'm curious why you decided against making an explicit binary and then a test target that just calls the binary entrypoint but with no arguments, as was described in the initial ticket? I tried this approach but then decided on this one because (at least for me in RustRover) I felt it would be easier to use / understand. making a different binary ended up being something like `cargo run -p datafusion-sqllogictest --bin sqllogictest` or `cargo run -p datafusion-sqllogictest --bin runner` (though maybe my Cargo.toml fu is not as good as it could be) And then when I started trying to add some documents on how to run this command, it got confusing quickly Thus I figured it would be easier to understand if it just looked like the test binary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
