alamb commented on code in PR #7242:
URL: https://github.com/apache/arrow-datafusion/pull/7242#discussion_r1401931717
##########
datafusion/physical-expr/src/aggregate/sum.rs:
##########
@@ -101,6 +106,43 @@ impl AggregateExpr for Sum {
}
fn create_accumulator(&self) -> Result<Box<dyn Accumulator>> {
+ if let DataType::List(field) = &self.data_type {
Review Comment:
> If we implement array aggregate function in array_expression.rs is there
any concern for the overall design?
Maybe we could put it in array_aggregates.rs (array_expressions.rs is
already quite substantial)
Upon further reflection I agree that it makes sense to keep ArraySum
separate from the normal Sum aggregator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
