jorisvandenbossche opened a new pull request, #38845:
URL: https://github.com/apache/arrow/pull/38845

   ### Rationale for this change
   
   See https://github.com/apache/arrow/issues/38618#issuecomment-1821252024 and 
below for the analysis. When deleting the dir contents, we use a GetFileInfo 
with recursive FileSelector to list all objects to delete, but when doing that 
the file paths for directories don't end in a trailing `/`, so for deleting 
explicitly created directories we need to add the `kSep` here as well to 
properly delete the object.
   
   ### Are these changes tested?
   
   I tested them manually with an actual S3 bucket. The problem is that MinIO 
doesn't have the same problem, and so it's not actually tested with the test I 
added using our MinIO testing setup.
   
   ### Are there any user-facing changes?
   
   Fixes the regression


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to