Dandandan commented on a change in pull request #9234:
URL: https://github.com/apache/arrow/pull/9234#discussion_r559225992
##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -288,6 +288,9 @@ fn group_aggregate_batch(
// Make sure we can create the accumulators or otherwise return an error
create_accumulators(aggr_expr).map_err(DataFusionError::into_arrow_external_error)?;
+ // Keys received in this batch
+ let mut batch_keys = vec![];
Review comment:
It checks for either an empty indices vec (which means no rows yet with
this key) or being the first row with this key in `or_insert_with`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
