pitrou commented on code in PR #38858:
URL: https://github.com/apache/arrow/pull/38858#discussion_r1403509162
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -951,7 +951,7 @@ class ClientBuilder {
client_config_.caPath =
ToAwsString(internal::global_options.tls_ca_dir_path);
}
- const bool use_virtual_addressing = options_.endpoint_override.empty();
+ const bool use_virtual_addressing = options_.use_virtual_addressing;
Review Comment:
This will break the current behavior where, if `endpoint_override` is set,
virtual addressing is disabled.
Perhaps we should make `use_virtual_addressing` a `std::optional<bool>`
instead?
Or perhaps we could call it `force_virtual_addressing` and have the
following logic:
```c++
const bool use_virtual_addressing = options_.endpoint_override.empty()
|| options_.force_virtual_addressing;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
