mapleFU commented on code in PR #38863:
URL: https://github.com/apache/arrow/pull/38863#discussion_r1403915078
##########
cpp/src/parquet/bloom_filter_reader.cc:
##########
@@ -63,9 +63,16 @@ std::unique_ptr<BloomFilter>
RowGroupBloomFilterReaderImpl::GetColumnBloomFilter
if (file_size <= *bloom_filter_offset) {
throw ParquetException("file size less or equal than bloom offset");
}
+ std::optional<int64_t> bloom_filter_length =
col_chunk->bloom_filter_length();
+ if (bloom_filter_length.has_value() &&
+ *bloom_filter_length + *bloom_filter_offset > file_size) {
+ throw ParquetException(
+ "bloom filter length + bloom filter offset greater than file size");
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]