edmondop opened a new pull request, #8316: URL: https://github.com/apache/arrow-datafusion/pull/8316
## Which issue does this PR close? This pr addresses #8194 and try to migrate all the tests from `aggregate.rs` to `sqlllogictests`. At the moment, the following tests have been migrated: - [ ] csv_query_array_agg_distinct - [x] aggregate - [x] aggregate_empty - [x] aggregate_avg - [x] aggregate_max - [x] aggregate_min - [x] aggregate_grouped - [x] aggregate_grouped_avg - [x] aggregate_grouped_empty - [x] aggregate_grouped_max - [x] aggregate_grouped_min - [x] aggregate_min_max_w_custom_window_frames - [x] aggregate_min_max_w_custom_window_frames_unbounded_start - [x] aggregate_avg_add - [x] case_sensitive_identifiers_aggregates - [x] count_basic - [ ] count_partitioned - [ ] count_aggregated - [ ] count_aggregated_cube - [x] count_multi_expr - [x] count_multi_expr_group_by - [x] simple_avg - [x] simple_mean - [ ] run_count_distinct_integers_aggregated_scenario - [ ] count_distinct_integers_aggregated_single_partition - [ ] count_distinct_integers_aggregated_multiple_partitions - [x] aggregate_with_alias - [ ] test_accumulator_row_accumulator For the non migrated tests, it seems that they have to do explicitly with partitioning such as https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/aggregates.rs#L409. Is it possible to exercise this behavior in SQL tests and verify it? Also for count_aggreagted_cube for example https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/aggregates.rs#L427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
