mrkn commented on a change in pull request #6302:
URL: https://github.com/apache/arrow/pull/6302#discussion_r559295194
##########
File path: cpp/src/arrow/ipc/metadata_internal.cc
##########
@@ -1349,17 +1349,22 @@ Status GetTensorMetadata(const Buffer& metadata,
std::shared_ptr<DataType>* type
return Status::IOError("Header-type of flatbuffer-encoded Message is not
Tensor.");
}
- int ndim = static_cast<int>(tensor->shape()->size());
+ flatbuffers::uoffset_t ndim = tensor->shape()->size();
- for (int i = 0; i < ndim; ++i) {
+ for (flatbuffers::uoffset_t i = 0; i < ndim; ++i) {
Review comment:
Changed.
##########
File path: cpp/src/arrow/ipc/metadata_internal.cc
##########
@@ -1349,17 +1349,22 @@ Status GetTensorMetadata(const Buffer& metadata,
std::shared_ptr<DataType>* type
return Status::IOError("Header-type of flatbuffer-encoded Message is not
Tensor.");
}
- int ndim = static_cast<int>(tensor->shape()->size());
+ flatbuffers::uoffset_t ndim = tensor->shape()->size();
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
