jonahgao commented on issue #8296: URL: https://github.com/apache/arrow-datafusion/issues/8296#issuecomment-1826476167
> I have examined how we can support merge_projections under this [PR](https://github.com/synnada-ai/arrow-datafusion/pull/201). It seems that we can support this feature, with this PR all of the optimizations related to the `Projection` is handled with a single rule. > > Also as part of that PR, I have changed projection merge logic, such that it doesn't always merges consecutive projections(when previous projection is used to cache complex computation for subsequent projection). With this support, the problem in this issue is resolved also. See [test](https://github.com/synnada-ai/arrow-datafusion/blob/81b55af099220c59787ce8b2bbf9ef5c4052973a/datafusion/sqllogictest/test_files/subquery.slt#L1023) A great job 🎉 ! I will leave this issue here, waiting for your PR to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
