alamb commented on code in PR #8313:
URL: https://github.com/apache/arrow-datafusion/pull/8313#discussion_r1405386301
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -2514,6 +2520,67 @@ mod tests {
.is_null(0));
}
+ #[test]
+ fn test_array_range() {
Review Comment:
@jayzhan211 and @Weijun-H I think what is happening is that people follow
the model of the existing code -- so as long as there are tests in
array_expressions (rather than .slt) that is what people will model.
What do you think about migrating (as part of another PR) all the existing
tests to sqllogictests -- this would likely result in all subsequent PRs
following the sqllogictests model
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
