emkornfield commented on code in PR #38867:
URL: https://github.com/apache/arrow/pull/38867#discussion_r1405604799
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -187,6 +188,11 @@ class PARQUET_EXPORT FileReader {
const std::vector<int>& row_group_indices, const std::vector<int>&
column_indices,
std::unique_ptr<::arrow::RecordBatchReader>* out) = 0;
+ virtual ::arrow::Status GetRecordBatchReader(
+ const std::vector<int>& row_group_indices, const std::vector<int>&
column_indices,
+ const std::shared_ptr<std::map<int, RowRangesPtr>>& row_ranges_map,
Review Comment:
Its also not clear to me that we should include both RowGroupIndices and
ranges within those indicies. It seems like a cleaner API to only include one
or the other (which also makes passing in ranges easier?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
