emkornfield commented on issue #38865: URL: https://github.com/apache/arrow/issues/38865#issuecomment-1827113267
I raised this issue on the PR but I think we should discuss in more detail: 1. API and implementation for RowRanges representation (there is already a similar to issue to this in https://github.com/apache/arrow/issues/37559). Part of the discussion is what functionality we want to support and complexity trade-offs, the API in the PR has a large set of manipulation functions). 2. API exposed. I'd suggest instead of the one proposed we go for something like: ``` ::arrow::Result<std::unique_ptr<RecordBatchReader>> GetRecordBatchReader(const RowRanges& rows_to_return, const std::vector<int>& column_indices); ``` helpers can be provided to construct initial row ranges from a set of row groups if needed, but it avoids having to track them separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
