seddonm1 opened a new pull request #9243:
URL: https://github.com/apache/arrow/pull/9243
I am throwing up a draft PR just to give people a heads up that I am working
through these.
**Changes**
I have had to make some changes to the existing implementations:
- `concat` had the incorrect behavior for how to handle NULLs where any null
would result in a NULL where the Postgres implementation documents: `NULL
arguments are ignored.`.
- `ltrim` and `rtrim` were implemented to support only the default space
character whereas Postgres supports an optional second parameter:
`ltrim('zzzytest', 'xyz')` so that has been updated.
**Questions**
- @jorgecarleitao I think we need this `Signature::Uniform` vs
`Signature::UniformEqual`. This came up with a `left` function that takes a
`(utf8, int64)` signature and it is not correct to try to cast both to `utf8`.
You can see my implementation here but perhaps you have a better method.
- @jorgecarleitao Do you have a nice way of throwing errors in the map
itself? See commented out Chr that I would appreciate your assistance:
https://github.com/apache/arrow/compare/master...seddonm1:postgres-string-functions?expand=1#diff-abe8768fe7124198cca7a84ad7b2c678b3cc8e5de3d1bc867d498536a2fdddc7R287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
