Weijun-H commented on code in PR #8268:
URL: https://github.com/apache/arrow-datafusion/pull/8268#discussion_r1405889591
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -2626,6 +2650,45 @@ select array_has_all(make_array(1,2,3), make_array(1,3)),
----
true false true false false false true true false false true false true
+query ?
Review Comment:
```suggestion
## array_distinct
query ?
```
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -1991,6 +1991,56 @@ pub fn array_intersect(args: &[ArrayRef]) ->
Result<ArrayRef> {
}
}
+/// array_distinct SQL function
+/// example: from list [1, 3, 2, 3, 1, 2, 4] to [1, 2, 3, 4]
+pub fn array_distinct(args: &[ArrayRef]) -> Result<ArrayRef> {
+ assert_eq!(args.len(), 1);
+
+ // handle null
+ if args[0].data_type() == &DataType::Null {
+ return Ok(args[0].clone());
+ }
+
+ let array = as_list_array(&args[0])?;
Review Comment:
Could you extend it to `LargeList` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
