bkietz commented on code in PR #37868:
URL: https://github.com/apache/arrow/pull/37868#discussion_r1406223634
##########
python/pyarrow/_dataset.pyx:
##########
@@ -96,27 +96,33 @@ def _get_parquet_symbol(name):
return _dataset_pq and getattr(_dataset_pq, name)
-cdef CFileSource _make_file_source(object file, FileSystem filesystem=None):
+cdef CFileSource _make_file_source(object file, FileSystem filesystem=None,
int64_t file_size=-1):
Review Comment:
Also, based on call sites below it looks like you mean to require kwargs for
filesystem and file_size
```suggestion
cdef CFileSource _make_file_source(object file, *, FileSystem
filesystem=None, int64_t file_size=-1):
```
##########
python/pyarrow/_dataset.pyx:
##########
@@ -96,27 +96,33 @@ def _get_parquet_symbol(name):
return _dataset_pq and getattr(_dataset_pq, name)
-cdef CFileSource _make_file_source(object file, FileSystem filesystem=None):
+cdef CFileSource _make_file_source(object file, FileSystem filesystem=None,
int64_t file_size=-1):
Review Comment:
Instead of coercing file_size here and also in make_fragment, could we
instead allow this function to accept None and move it all here?
```suggestion
cdef CFileSource _make_file_source(object file, FileSystem filesystem=None,
object file_size=None):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
