lidavidm commented on code in PR #1320: URL: https://github.com/apache/arrow-adbc/pull/1320#discussion_r1406409206
########## .github/workflows/csharp.yml: ########## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: C# + +on: + push: + paths: + - '.github/workflows/csharp.yml' + - 'ci/scripts/csharp_*' + - 'csharp/**' + pull_request: + paths: + - '.github/workflows/csharp.yml' + - 'ci/scripts/csharp_*' + - 'csharp/**' + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + + ubuntu: + name: AMD64 Ubuntu 18.04 C# ${{ matrix.dotnet }} + runs-on: ubuntu-latest + if: ${{ !contains(github.event.pull_request.title, 'WIP') }} + timeout-minutes: 15 + strategy: + fail-fast: false + matrix: + dotnet: ['7.0.x'] + steps: + - name: Install C# + uses: actions/setup-dotnet@v3 + with: + dotnet-version: ${{ matrix.dotnet }} + - name: Checkout ADBC + uses: actions/checkout@v4 + with: + fetch-depth: 0 + submodules: recursive + - name: Install Source Link + shell: bash + run: dotnet tool install --global sourcelink + - name: Build + shell: bash + run: ci/scripts/csharp_build.sh $(pwd) Review Comment: I guess we're not using the docker-compose definition? Do we need it at all? ########## .github/workflows/csharp.yml: ########## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: C# + +on: + push: + paths: + - '.github/workflows/csharp.yml' + - 'ci/scripts/csharp_*' + - 'csharp/**' + pull_request: + paths: + - '.github/workflows/csharp.yml' + - 'ci/scripts/csharp_*' + - 'csharp/**' + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + + ubuntu: + name: AMD64 Ubuntu 18.04 C# ${{ matrix.dotnet }} Review Comment: nit: ubuntu-latest is 22.04 now ########## .github/workflows/csharp.yml: ########## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: C# + +on: + push: + paths: + - '.github/workflows/csharp.yml' + - 'ci/scripts/csharp_*' + - 'csharp/**' + pull_request: + paths: + - '.github/workflows/csharp.yml' + - 'ci/scripts/csharp_*' + - 'csharp/**' + +concurrency: + group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + + ubuntu: Review Comment: If the platforms are identical, could we consolidate them into a matrix argument? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
