mapleFU commented on code in PR #38885:
URL: https://github.com/apache/arrow/pull/38885#discussion_r1407194544


##########
cpp/src/arrow/dataset/dataset_writer.cc:
##########
@@ -621,11 +621,18 @@ class DatasetWriter::DatasetWriterImpl {
         backpressure = writer_state_.open_files_throttle.Acquire(1);
         if (!backpressure.is_finished()) {
           
EVENT_ON_CURRENT_SPAN("DatasetWriter::Backpressure::TooManyOpenFiles");
+          
writer_state_.rows_in_flight_throttle.Release(next_chunk->num_rows());

Review Comment:
   Hmm I think the best way is using something like a "RAII Guard" here. This 
might need kind of refactor the throttle type here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to