Veeupup commented on PR #8332: URL: https://github.com/apache/arrow-datafusion/pull/8332#issuecomment-1829650149
> LGTM! > > @Veeupup Before closing #8324, how about function like `test_align_array_dimensions`? We should either remove it or move it to dfcommon::utils if it is possible to be used elsewhere. Sure! But I found that `align_array_dimensions` is only used in `array_expressions.rs` and its signature is not `pub`. So it would be fine to just keep in `array_expressions.rs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
