tustvold commented on code in PR #5102:
URL: https://github.com/apache/arrow-rs/pull/5102#discussion_r1407906359
##########
parquet/src/record/reader.rs:
##########
@@ -274,6 +274,8 @@ impl TreeBuilder {
row_group_reader,
)?;
+ path.push(field_name);
Review Comment:
Perhaps we could just return the Reader, as opposed to adding a value to
path only to pop it back off. The call to Reader::option also appears to be
redundant as we've already checked the repetition level is not optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
