alamb commented on code in PR #8350:
URL: https://github.com/apache/arrow-datafusion/pull/8350#discussion_r1408504735
##########
datafusion/expr/src/expr.rs:
##########
@@ -1219,8 +1226,8 @@ impl fmt::Display for Expr {
write!(f, " NULLS LAST")
}
}
- Expr::ScalarFunction(ScalarFunction { func_def, args }) => {
- fmt_function(f, func_def.name(), false, args, true)
+ Expr::ScalarFunction(fun) => {
Review Comment:
Doing so I think makes code like this easier / less inceptionish
(Expr::ScalarFunction vs expr::ScalarFunction 🤯 )
##########
datafusion/expr/src/expr.rs:
##########
@@ -1219,8 +1226,8 @@ impl fmt::Display for Expr {
write!(f, " NULLS LAST")
}
}
- Expr::ScalarFunction(ScalarFunction { func_def, args }) => {
- fmt_function(f, func_def.name(), false, args, true)
+ Expr::ScalarFunction(fun) => {
Review Comment:
Doing so I think makes code like this easier / less inceptionish
(Expr::ScalarFunction vs expr::ScalarFunction 🤯 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
