Jesse-Bakker commented on code in PR #8312:
URL: https://github.com/apache/arrow-datafusion/pull/8312#discussion_r1408951755
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1917,6 +1923,84 @@ impl Filter {
Ok(Self { predicate, input })
}
+
+ fn is_scalar(&self) -> bool {
+ let schema = self.input.schema();
+
+ let functional_dependencies =
self.input.schema().functional_dependencies();
+ let unique_keys = functional_dependencies.iter().filter(|dep| {
+ let nullable = dep.nullable
+ && dep
+ .source_indices
+ .iter()
+ .any(|&source| schema.field(source).is_nullable());
+ !nullable
+ && dep.mode == Dependency::Single
+ && dep.target_indices.len() == schema.fields().len()
+ });
+
+ /// Splits a conjunctive [`Expr`] such as `A AND B AND C` => `[A, B,
C]`
+ pub fn split_conjunction(expr: &Expr) -> Vec<&Expr> {
Review Comment:
There are quite a few functions in `datafusion-optimizer::utils` which only
depend on `LogicalPlan` or `Expr` and are good candidates to move to
`datafusion-expr::utils`. I'll file a follow-up PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
