Jefffrey commented on code in PR #5135:
URL: https://github.com/apache/arrow-rs/pull/5135#discussion_r1409109867


##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -385,13 +385,28 @@ impl<T: AsyncFileReader + Send + 'static> 
ParquetRecordBatchStreamBuilder<T> {
             offset: self.offset,
         };
 
+        // Ensure schema of ParquetRecordBatchStream respects projection, and 
does
+        // not store metadata (same as for ParquetRecordBatchReader and 
emitted RecordBatches)
+        let projected_fields = match reader.fields.as_deref().map(|pf| 
&pf.arrow_type) {

Review Comment:
   I was a bit worried about this, as I couldn't find a straightforward way 
that the schema was constructed from ParquetField + ProjectionMask, as it seems 
done in the ArrayReader construction indeed.
   
   Edit: wasn't aware of 
https://docs.rs/parquet/latest/parquet/arrow/fn.parquet_to_arrow_field_levels.html,
 will check it out :+1: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to