zeroshade commented on code in PR #38443:
URL: https://github.com/apache/arrow/pull/38443#discussion_r1409477233
##########
cpp/src/arrow/c/bridge.cc:
##########
@@ -260,7 +264,7 @@ struct SchemaExporter {
// Dictionary type: parent struct describes index type,
// child dictionary struct describes value type.
RETURN_NOT_OK(VisitTypeInline(*dict_type.index_type(), this));
- dict_exporter_.reset(new SchemaExporter());
+ dict_exporter_ = std::make_unique<SchemaExporter>();
Review Comment:
In that case, wouldn't it be better to keep this as calling `.reset` rather
than switch to `make_unique`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
