alamb commented on issue #8347:
URL: 
https://github.com/apache/arrow-datafusion/issues/8347#issuecomment-1832226281

   > it seems like we already unified `WindowFunction` in
   
   That is an excellent point. Thank you for the research @haohuaijin 
   
   Maybe we could rename 
https://github.com/apache/arrow-datafusion/blob/4c914ea1e5d3dc61f3552adcffb8356c90d73bac/datafusion/expr/src/window_function.rs#L35-L44
 to `WindowFunctionDefinition` so we didn't have so many things named 
`WindowFunction` and to mirror the structure of ScalarFunctions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to