alamb opened a new pull request, #8364:
URL: https://github.com/apache/arrow-datafusion/pull/8364
## Which issue does this PR close?
N/A
## Rationale for this change
It has bothered since it was introduced in #8006 that the AggregateExec uses
something from the window exec module
What is really happening is that they both are being told how the input is
ordered relative to important columns (e.g. partitioning or grouping).
For example, the `ordering_mode` in this output:
```
| AggregateExec: mode=Partial, gby=[region@0 as region,
date_bin(600000000000, time@1) as
date_bin_gapfill(IntervalMonthDayNano("600000000000"),cpu.time)],
aggr=[AVG(cpu.user)], ordering_mode=Sorted |
|
```
Is actually the result of the `PartitionSearchMode`
## What changes are included in this PR?
1. Move `PartitionSearchMode` into its own module
2. Add some comments
I would also like to propose renaming the structure to something that
doesn't have the word Partitioning in it
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
1. Changed a `use` path for `PartitionSearchMode`
2. Better documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
