tustvold commented on code in PR #5149:
URL: https://github.com/apache/arrow-rs/pull/5149#discussion_r1409820957
##########
arrow-schema/src/fields.rs:
##########
@@ -99,6 +100,93 @@ impl Fields {
.all(|(a, b)| Arc::ptr_eq(a, b) || a.contains(b))
}
+ /// Performs a depth-first scan of [`Fields`] filtering the [`FieldRef`]
with no children
Review Comment:
I incoporated this into
https://github.com/apache/arrow-rs/pull/5149/commits/8d9795069c8244820b2107c76f46d9d484ee4740.
I tweaked the wording a little as the depth-first part is critical to
understanding what the leaf ordering means. I also added some comments to the
doctest to highlight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]