danepitkin commented on code in PR #38991:
URL: https://github.com/apache/arrow/pull/38991#discussion_r1410961193
##########
java/format/src/main/java/org/apache/arrow/flatbuf/Feature.java:
##########
@@ -37,26 +37,23 @@
* to facilitate exchanging and comparing bitmaps for supported
* features.
*/
+@SuppressWarnings("unused")
public final class Feature {
private Feature() { }
/**
* Needed to make flatbuffers happy.
*/
- public static final long UNUSED = 0;
+ public static final long UNUSED = 0L;
/**
* The stream makes use of multiple full dictionaries with the
* same ID and assumes clients implement dictionary replacement
* correctly.
*/
- public static final long DICTIONARY_REPLACEMENT = 1;
+ public static final long DICTIONARY_REPLACEMENT = 1L;
/**
* The stream makes use of compressed bodies as described
* in Message.fbs.
*/
- public static final long COMPRESSED_BODY = 2;
-
- public static final String[] names = { "UNUSED", "DICTIONARY_REPLACEMENT",
"COMPRESSED_BODY", };
-
- public static String name(int e) { return names[e]; }
Review Comment:
That's fair. I wouldn't want to modify the format itself for this tbh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
