alamb commented on code in PR #8353:
URL: https://github.com/apache/arrow-datafusion/pull/8353#discussion_r1411293592
##########
datafusion/physical-expr/src/aggregate/mod.rs:
##########
@@ -102,6 +102,21 @@ pub trait AggregateExpr: Send + Sync + Debug +
PartialEq<dyn Any> {
"AggregateExpr: default name"
}
+ /// Returns Aggregate Fucntion Name
+ fn func_name(&self) -> &str;
+
+ /// Human readable name such as `"MIN(c2)"` or `"RANK()"`. The default
+ /// implementation returns `"FUNCTION_NAME(args)"`
+ fn display_name(&self) -> String {
Review Comment:
I was thinking that we could add a `name` field to `WindowFunction` upon
creation to mirror what happens with AggregateFunction. That way the code would
be consistent and we can use the same pattern that works for AggregateFunction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
