AlenkaF commented on PR #38472: URL: https://github.com/apache/arrow/pull/38472#issuecomment-1835497948
I am not sure about the failing builds: - [AMD64 Ubuntu 22.04 C++ ASAN UBSAN](https://github.com/apache/arrow/actions/runs/7050402985/job/19191028912?pr=38472#step:6:3004) is failing due to a memory leak in the dlpack test with (not sure what is going on but am playing around with thest to see if I can fix it): ``` ================================================================= ==5316==ERROR: LeakSanitizer: detected memory leaks Direct leak of 1144 byte(s) in 11 object(s) allocated from: #0 0x55959388606d in operator new(unsigned long) (/build/cpp/debug/arrow-dlpack-test+0x10506d) (BuildId: 6eecfc46ecb410ea9bef89c63c4a74ec4e3333cc) #1 0x7f47140c9efc in arrow::dlpack::ExportArray(std::shared_ptr<arrow::Array> const&, DLManagedTensor**) /arrow/cpp/src/arrow/c/dlpack.cc:87:29 #2 0x55959388e691 in arrow::dlpack::$_0::operator()(std::shared_ptr<arrow::Array> const&, std::shared_ptr<arrow::DataType>, DLDataTypeCode, long) const /arrow/cpp/src/arrow/c/dlpack_test.cc:41:3 #3 0x55959388ac56 in arrow::dlpack::TestExportArray_TestSupportedArray_Test::TestBody() /arrow/cpp/src/arrow/c/dlpack_test.cc:85:5 #4 0x7f47270e67fe in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/usr/local/lib/libarrow_testing.so.1500+0xda47fe) (BuildId: d0574061a61e73aebf3ce34a43c933ba7636c822) ``` - [Lint C++, Python, R, Docker, RAT](https://github.com/apache/arrow/actions/runs/7050402985/job/19191028912?pr=38472#logs) is failing but I am not sure if it is the old R linter error and I need to rebase. So will try with that. - Other failing builds already have an issue opened and resolved, so will see if rebase helped: https://github.com/apache/arrow/issues/39003 Otherwise I think this PR is ready for review and will mark it as such after rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
