alamb commented on code in PR #8369:
URL: https://github.com/apache/arrow-datafusion/pull/8369#discussion_r1412024768
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -130,6 +130,10 @@ fn string_to_timestamp_nanos_shim(s: &str) -> Result<i64> {
}
/// to_timestamp SQL function
+///
+/// Note: `to_timestamp` returns `Timestamp(Nanosecond)`. The supported range
for integer input is between `-9223372037` and `9223372036`.
Review Comment:
```suggestion
/// Note: `to_timestamp` returns `Timestamp(Nanosecond)` though its
arguments are interpreted as **seconds**. The supported range for integer input
is between `-9223372037` and `9223372036`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
