rok commented on PR #37533: URL: https://github.com/apache/arrow/pull/37533#issuecomment-1837040423
> Didn't yet look in detail, but added some quick drive-by comments. And thanks for working on this! Thanks for the review @jorisvandenbossche ! I've addressed your points. > Can you also add some tests for the new Scalar class? Will do. I'll try to reuse the ones I'm adding in https://github.com/apache/arrow/pull/38008/files > Currently, for the Python bindings, you added a `get_tensor(i)` method on the array class, but wouldn't make sense to (also/instead) add a `to_tensor()` method on the scalar class, since this is to get a Tensor for a single element (scalar) of the array? Indeed, added. I've also made the `get_tensor` logic in c++ be type method that takes a scalar as opposed to array method that takes an index so that it's easier to call from Python. (This cam out of a discussion in https://github.com/apache/arrow/pull/38008) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
