viirya commented on code in PR #8394:
URL: https://github.com/apache/arrow-datafusion/pull/8394#discussion_r1412855929
##########
datafusion/core/src/physical_optimizer/pruning.rs:
##########
@@ -66,43 +66,57 @@ use log::trace;
/// min_values("X") -> None
/// ```
pub trait PruningStatistics {
- /// return the minimum values for the named column, if known.
- /// Note: the returned array must contain `num_containers()` rows
+ /// Return the minimum values for the named column, if known.
+ ///
+ /// If the minimum value for a particular container is not known, the
+ /// returned array should have `null` in that row. If the minimum value is
+ /// not know for any row, return `None`.
Review Comment:
```suggestion
/// not known for any row, return `None`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
