my-vegetable-has-exploded commented on code in PR #2156:
URL: https://github.com/apache/arrow-datafusion/pull/2156#discussion_r1413122706
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -318,7 +408,13 @@ impl InListExpr {
impl std::fmt::Display for InListExpr {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
if self.negated {
- write!(f, "{} NOT IN ({:?})", self.expr, self.list)
+ if self.set.is_some() {
+ write!(f, "{} NOT IN (SET) ({:?})", self.expr, self.list)
+ } else {
+ write!(f, "{} NOT IN ({:?})", self.expr, self.list)
+ }
+ } else if self.set.is_some() {
+ write!(f, "Use {} IN (SET) ({:?})", self.expr, self.list)
Review Comment:
Sorry to bother you, is use in the "Use {} IN (SET) ({:?})" a typo?
@Ted-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
