bkietz commented on issue #36612: URL: https://github.com/apache/arrow/issues/36612#issuecomment-1838841774
> What we would need here is some functionality to make arrow::util::span compatible with std::span I think a better approach would be an `#if` which aliases `std::span` to `arrow::util::span` if possible, falling back to the backport otherwise. We don't have a CI job which compiles with c++20 but there is a [crossbow task](https://github.com/apache/arrow/blob/84c15da1997559c37841dc16f9e2c70c643dd9d2/dev/tasks/tasks.yml#L1200-L1209) which should pass if the two are compatible. If greater rigor is desired, expanding `span_test.cc` should suffice since that will be run against std::span on the crossbow job and against the backport otherwise. It would probably also be good to expand the number of jobs we're running at c++20; I'd be surprised by not shocked if at least one STL's std::span implementation differed in some annoying way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
