likun666661 commented on PR #38790: URL: https://github.com/apache/arrow/pull/38790#issuecomment-1838851834
> Thanks for your contribution! The proposal sounds good: caching at node level is indeed better. I have a couple of questions regarding the implementation: > > 1. Could you resolve the conflicts so that we can initiate the CI checks? > 2. I see that schema checks are completely removed. Will invalid execution happen, e.g. `Projector` of one type executed on a `RecordBatch` of another type? If so, is it possible to keep the checks on types and only skip the checks on names? 1. I will do this later. 2. For second，gandiva expr validator will check the tree expr. So , when in function node ,it will check the fieldnode type and thus it will checks on types and only skip the checks on names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
