pitrou commented on code in PR #39009: URL: https://github.com/apache/arrow/pull/39009#discussion_r1414115920
########## cpp/src/arrow/filesystem/test_util.h: ########## @@ -74,6 +74,10 @@ void CreateFile(FileSystem* fs, const std::string& path, const std::string& data ARROW_TESTING_EXPORT void SortInfos(FileInfoVector* infos); +// Create a copy of a FileInfo vector sorted by lexicographic path order +ARROW_TESTING_EXPORT +std::vector<FileInfo> SortedInfos(const std::vector<FileInfo>& infos); Review Comment: Nit, but nice addition anyway ```suggestion FileInfoVector SortedInfos(const FileInfoVector& infos); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
