felipecrv commented on PR #39058:
URL: https://github.com/apache/arrow/pull/39058#issuecomment-1839212730

   > > I think that this is convenient but this is different from other 
filesystem implementations...
   > 
   > We should not diverge from the filesystem spec (as described in the 
[FileSystem class 
docstrings](https://github.com/apache/arrow/blob/f7947cc21bf78d67cf5ac1bf1894b5e04de1a632/cpp/src/arrow/filesystem/filesystem.h#L266-L270)
 ). The end goal is for all implementations to expose a similar behavior.
   > 
   > Also, at some point the Azure fs implementation will have to implement and 
pass the [generic filesystem 
tests](https://github.com/apache/arrow/blob/f7947cc21bf78d67cf5ac1bf1894b5e04de1a632/cpp/src/arrow/filesystem/test_util.h#L120-L245),
 which do have a test [for this 
situation](https://github.com/apache/arrow/blob/f7947cc21bf78d67cf5ac1bf1894b5e04de1a632/cpp/src/arrow/filesystem/test_util.cc#L555-L558).
   
   I agree. I think we should fix https://github.com/apache/arrow/issues/38772 
before adding more operations. I implemented the `GetFileInfo(select)` with 
this as an assumption. `CopyFile` shouldn't implicitly create directories, so 
we need a way to check an empty directory exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to