jduo commented on PR #39011: URL: https://github.com/apache/arrow/pull/39011#issuecomment-1839493249
It seems these changes are not usable without modularizing memory-core. arrow-vector makes use of Preconditions and BufferAllocator heavily. Since these are declared in an unnamed module (memory-core), the user has to add --open-reads=org.apache.arrow.vector=ALL-UNNAMED. This doesn't fail when running arrow-vector tests because surefire adds this automatically for this module but fails any other test that depends on arrow-vector. The Preconditions class could be moved to a new utils module, but that doesn't deal with BufferAllocator which is very much part of memory-core out of necessity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
