QuenKar commented on PR #8411: URL: https://github.com/apache/arrow-datafusion/pull/8411#issuecomment-1840499218
nice idea！ 获取 Outlook for iOS<https://aka.ms/o0ukef> ________________________________ 发件人: Dani?l Heres ***@***.***> 发送时间: Tuesday, December 5, 2023 6:35:21 PM 收件人: apache/arrow-datafusion ***@***.***> 抄送: Wei ***@***.***>; Mention ***@***.***> 主题: Re: [apache/arrow-datafusion] feat: ScalarValue from String (PR #8411) @Dandandan commented on this pull request. ________________________________ In datafusion/common/src/scalar.rs<https://github.com/apache/arrow-datafusion/pull/8411#discussion_r1415328153>: > + let scalar = ScalarValue::from("foo".to_string()); + assert_eq!(scalar, ScalarValue::Utf8(Some("foo".to_string()))); One tricky might be removing From<&str> implementqtion and seeing if something fails to compile. ― Reply to this email directly, view it on GitHub<https://github.com/apache/arrow-datafusion/pull/8411#discussion_r1415328153>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALLY5Y3PYJ5Z6H67GMIGS4DYH32GTAVCNFSM6AAAAABAFRMVO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRUGY4DONBUGU>. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
