pitrou commented on code in PR #39009:
URL: https://github.com/apache/arrow/pull/39009#discussion_r1415365612
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -1103,7 +1330,12 @@ Result<FileInfo> AzureFileSystem::GetFileInfo(const
std::string& path) {
}
Result<FileInfoVector> AzureFileSystem::GetFileInfo(const FileSelector&
select) {
- return Status::NotImplemented("The Azure FileSystem is not fully
implemented");
+ Azure::Core::Context context;
+ Azure::Nullable<int32_t> page_size_hint; // unspecified
+ FileInfoVector results;
+ RETURN_NOT_OK(
+ impl_->GetFileInfoWithSelector(context, page_size_hint, select,
&results));
+ return std::move(results);
Review Comment:
I don't think the `std::move` is necessary at all? The moving should happen
nevertheless AFAIU.
cc @bkietz for advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
