mapleFU commented on code in PR #39065:
URL: https://github.com/apache/arrow/pull/39065#discussion_r1416924508
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -893,20 +902,29 @@ Result<std::vector<compute::Expression>>
ParquetFileFragment::TestRowGroups(
return std::vector<compute::Expression>{};
}
+ const SchemaField* schema_field = nullptr;
for (const FieldRef& ref : FieldsInExpression(predicate)) {
ARROW_ASSIGN_OR_RAISE(auto match, ref.FindOneOrNone(*physical_schema_));
-
if (match.empty()) continue;
- if (statistics_expressions_complete_[match[0]]) continue;
- statistics_expressions_complete_[match[0]] = true;
+ schema_field = &manifest_->schema_fields[match[0]];
+
+ for (size_t i = 1; i < match.indices().size(); ++i) {
+ if (schema_field->field->type()->id() != Type::STRUCT) {
+ return Status::Invalid("nested paths only supported for structs");
+ }
Review Comment:
Would you mind add a test for the "List/Map" filter doesn't work in cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
