my-vegetable-has-exploded commented on code in PR #8427:
URL: https://github.com/apache/arrow-datafusion/pull/8427#discussion_r1417029726
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -434,6 +434,16 @@ pub async fn from_substrait_rel(
None => plan_err!("JoinRel without join condition is not
allowed"),
}
}
+ Some(RelType::Cross(cross)) => {
+ let left: LogicalPlanBuilder = LogicalPlanBuilder::from(
+ from_substrait_rel(ctx, cross.left.as_ref().unwrap(),
extensions).await?,
+ );
+ let right = LogicalPlanBuilder::from(
+ from_substrait_rel(ctx, cross.right.as_ref().unwrap(),
extensions)
+ .await?,
+ );
+ left.cross_join(right.build()?)?.build()
Review Comment:
get it! thanks @waynexia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
