dr2chase commented on PR #39087: URL: https://github.com/apache/arrow/pull/39087#issuecomment-1843516932
How much longer are you supporting Go 1.19? I can certainly do build constraints, but that makes the change larger and a bit less obvious exactly what I changed, so if it's just a matter of waiting a few months, that's also possible. One thing to be aware of for Go 1.21 and beyond is that higher-versioned go.mod files will either download the higher-version toolchain (not necessarily what you want in CI) or fail to build. This would be a problem if, say, go.mod specified 1.22 and you tried to build with 1.21. This is motivated by the semantic change to iteration variable lifetime coming in Go 1.22; compiling a 1.22 for loop with a 1.21 semantics could silently introduce a bug. I think this is overall good, but it may cause you problems if you aren't expecting this. The newer compilers do know the older-language-version semantics, and also do per-file version upgrades as specified in version-matched build tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
