alamb commented on PR #5176: URL: https://github.com/apache/arrow-rs/pull/5176#issuecomment-1843674181
> Perhaps @alamb or @viirya might have thoughts on this? I think making `u128` an "`ArrowNativeType`" when there are no actual arrays that use them as native types is confusing 🤔 > I'm working on an arrow-rs interop feature https://github.com/mbrobbel/narrow/pull/100 for [narrow](https://github.com/mbrobbel/narrow). For the fixed size physical layout I'm trying to support ["values each having the same physical slot width typically measured in bytes"](https://github.com/apache/arrow/blob/92723f34f8df40b35e5840e61011c00766808014/docs/source/format/Columnar.rst?plain=1#L243-L244) via [FixedSize](https://github.com/mbrobbel/narrow/blob/main/src/fixed_size.rs) (which is like ArrowNativeType for that crate). To make ArrowNativeType a supertrait of FixedSize (which is required to make the interop work) it needs these implementations. I don't fully understand this -- given there is no Arrow array that will have an `ArrowNativeType` of `u128` etc. is changing `ArrowNativeType` the only way to implement an interop layer ? Is there an approach where you could implement conversions for an array to `FixedSize` with dynamic dispatch (e.g. `match data_type { .... } `)? You would have to list all the types, but that is feasible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
