alamb commented on issue #8355: URL: https://github.com/apache/arrow-datafusion/issues/8355#issuecomment-1843702655
> I have tried to move the `produce_one_row` to `MemoryExec` in #8412, but it wasn't straight forward as there are no `try_into_physical_plan` and `try_from_physical_plan` implemented for `MemoryExec`. > > Anyway I have tried to implement the physical plan, but since `MemoryExec` contains `dyn Array` for storing it's partitions it's a little bit tricky to serialize it to proto, the best way coming to my mind is to json serialize it as a string field in proto. > > I can do that, but before I wanted to get feedback here and make sure if that's a good path to go? @alamb @tustvold @crepererum The serialization is a good point What about perhaps making a new `OneRowExec` instead of reusing `MemoryExec` ? I think the code would be fairly straightforward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
